Author |
Topic |
|
aprit
Starting Member
USA
8 Posts |
Posted - February 12 2006 : 10:57:11
|
Hello Support,
While customizing vpasp, in the file shopcustomer.asp (validateData routine) here is the piece of code:
strPassword1 = Request.Form("strPassword1") strPassword2 = Request.Form("strPassword2") strgiftcertificate = request("strgiftcertificate") strCoupon = request("strcoupon") blnMailList = request("blnMaillist")
Last 3 lines are wrong and you better check all ValidateData routines.
I'm wondering if you people have QA or your customers are gunea pigs and do QA.
|
|
rvaga
VP-CART Super User
USA
254 Posts |
Posted - February 12 2006 : 12:02:58
|
aprit states: "I'm wondering if you people have QA or your customers are gunea pigs and do QA. "
You have 6 posts on this forum. Not fair on your part to imply that the VPASP folks are somehow second-rate. Once you have been around awhile, you will recognize the fact that VPASP support is exceedingly conscientious in responding to problems/issues, and that a cart that is constantly improving will have unforseen code errors (assuming you are accurate regarding the code).
Do they have gunea pigs in Australia?? I thought they just had those jumpy-things with the big feet & big ears & long nose -- and a nasty attitude.
No, wait... that's my mother in law...
|
|
|
devshb
Senior Member
United Kingdom
1904 Posts |
Posted - February 12 2006 : 12:41:43
|
as far as I know, "request" will have exactly the same effect/syntax as "request.form" at the point where that code's being run; it might not be perfectly tidy to do that coding-wise, but it'll still work fine.
I'm not 100% sure of the fall-through logic for a request without the extra ".querystring" or ".form" but I think it just uses ".form" by default when nothing's specified.
Personally I always specify .querystring or .form and code-up my own fall-through logic which is relevant to the context, but I don't think vpasp's code will cause any problems; it's just a case of tidyness.
( I'm not sure about guinea pigs either, but they do have a really cute little rare animal called a bilby - http://www.easterbilby.com.au/default.asp http://australian-animals.net/bilby.htm )
Simon Barnaby Developer [email protected] www.BigYellowZone.com Web Design, Online Marketing and VPASP addons |
Edited by - devshb on February 12 2006 12:51:31 |
|
|
aprit
Starting Member
USA
8 Posts |
Posted - February 12 2006 : 12:46:17
|
Didn't mean to insult your mother in law, or anybody else. Assuming I'm accurate - it's a fact, open this file and check ValidateData routine. Check other ValidateData routine as well. Unfortunatly, It's not the only thing I ran into. Not saying a bad word about the package, espacially for the money. Do not want to look snobby but this sort of things could be avoided. |
|
|
aprit
Starting Member
USA
8 Posts |
Posted - February 12 2006 : 13:02:40
|
Devshb,
Request object contains the following collections: ClientCertificate Cookies Form Item QueryString ServerVariables
Which one you reffer to? It may accidently work, most likely not. |
|
|
Doug Page
VP-CART New User
Canada
85 Posts |
Posted - February 12 2006 : 16:01:22
|
The syntax is: Request[.collection|property|method](variable)
All request object variables can be accessed directly by calling Request(variable) without the collection name. In this case, the Web server searches the collections in the following order:
QueryString Form Cookies ClientCertificate ServerVariables
|
|
|
|
Topic |
|